Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

election: update leadership_test.go #6400

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

happy-v587
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #6399

What is changed and how does it work?

fix test code

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 4, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels May 4, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and lhy1024 May 4, 2023 03:42
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 4, 2023

Hi @HappyUncle. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label May 4, 2023
Signed-off-by: HappyUncle <code4happy@gmail.com>
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (a4f9af3) 75.04% compared to head (871a251) 75.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6400      +/-   ##
==========================================
- Coverage   75.04%   75.03%   -0.01%     
==========================================
  Files         408      408              
  Lines       41112    41112              
==========================================
- Hits        30854    30850       -4     
+ Misses       7574     7569       -5     
- Partials     2684     2693       +9     
Flag Coverage Δ
unittests 75.03% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented May 5, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 5, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2023
@rleungx
Copy link
Member

rleungx commented May 5, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 5, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 5, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 871a251

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2023
@ti-chi-bot ti-chi-bot bot merged commit 566beda into tikv:master May 5, 2023
@happy-v587 happy-v587 deleted the patch-2 branch May 6, 2023 03:09
zeminzhou pushed a commit to zeminzhou/pd that referenced this pull request May 8, 2023
close tikv#6399

fix test code

Signed-off-by: HappyUncle <code4happy@gmail.com>
zeminzhou pushed a commit to zeminzhou/pd that referenced this pull request May 10, 2023
close tikv#6399

fix test code

Signed-off-by: HappyUncle <code4happy@gmail.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

election: Incorrect test case
3 participants