Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storelimit: impl fead back by snapshot report (#6161) #6349

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 20, 2023

This is an automated cherry-pick of #6161

What problem does this PR solve?

Issue Number: Close #6147

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Master

image

In this PR
image

Code changes

Side effects

  • Increased code complexity

Related changes

Release note

`store-limit-version` default value 'v1'. if it  be set as "v2", user don't need to add additional config to speed up the scale-out/scale-in, because the limit has been auto adjusted through the snapshot executing details.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 47.54% and project coverage change: -0.23 ⚠️

Comparison is base (5f99e0c) 75.29% compared to head (606957d) 75.06%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #6349      +/-   ##
===============================================
- Coverage        75.29%   75.06%   -0.23%     
===============================================
  Files              408      408              
  Lines            40414    40465      +51     
===============================================
- Hits             30428    30377      -51     
- Misses            7356     7441      +85     
- Partials          2630     2647      +17     
Flag Coverage Δ
unittests 75.06% <47.54%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/core/constant/kind.go 47.27% <0.00%> (-11.82%) ⬇️
pkg/schedule/config/config.go 33.33% <ø> (ø)
pkg/schedule/operator/influence.go 89.74% <ø> (ø)
pkg/statistics/store_collection.go 88.95% <16.66%> (-2.62%) ⬇️
pkg/core/store.go 77.62% <28.57%> (-1.31%) ⬇️
pkg/core/storelimit/store_limit.go 87.50% <50.00%> (-1.98%) ⬇️
server/cluster/cluster.go 81.83% <62.50%> (-0.20%) ⬇️
pkg/core/storelimit/sliding_window.go 80.00% <75.00%> (-3.61%) ⬇️
server/config/config.go 75.76% <100.00%> (+0.10%) ⬆️
server/config/persist_options.go 92.54% <100.00%> (+0.02%) ⬆️

... and 26 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2023
@bufferflies
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 21, 2023
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 21, 2023
add configuration for store-limit-version
close tikv#6147

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@bufferflies bufferflies force-pushed the cherry-pick-6161-to-release-7.1 branch from 5a895f6 to 606957d Compare April 21, 2023 06:27
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 606957d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2023
@bufferflies bufferflies removed status/can-merge Indicates a PR has been approved by a committer. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 21, 2023
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2023
@ti-chi-bot ti-chi-bot merged commit 715a78d into tikv:release-7.1 Apr 21, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants