Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule: it can transfer leader between the different rule #6200

Merged
merged 2 commits into from
Mar 21, 2023
Merged

rule: it can transfer leader between the different rule #6200

merged 2 commits into from
Mar 21, 2023

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Mar 21, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #6195

What is changed and how does it work?

1. role can be transfer when their's rule role is same.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Mar 21, 2023
@bufferflies bufferflies requested review from rleungx and CabinfeverB and removed request for JmPotato and HunDunDM March 21, 2023 07:56
nolouch
nolouch approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2023
@CabinfeverB
Copy link
Member

/run-check-issue-triage-complete

@bufferflies
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2023
@bufferflies
it can transfer leader between the different rule
e3c5e18 
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies bufferflies removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2023
@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e3c5e18

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2023
@ti-chi-bot
Copy link
Member

@bufferflies: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 07523d6 into tikv:master Mar 21, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 21, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #6202.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 21, 2023
@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#6200
cd88ea1 
close tikv#6195

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 21, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #6203.

ti-chi-bot added a commit that referenced this pull request Mar 21, 2023
@ti-chi-bot @bufferflies @lhy1024
rule: it can transfer leader between the different rule (#6200) (#6203)
c6ea772 
close #6195, ref #6200

1. role can be transfer when their's rule role is same.

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: bufferflies <1045931706@qq.com>
Co-authored-by: lhy1024 <admin@liudos.us>
CabinfeverB pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 22, 2023
@ti-chi-bot @bufferflies
@lhy1024 @CabinfeverB
rule: it can transfer leader between the different rule (tikv#6200) (t…
4a302ee 
…ikv#6203)

close tikv#6195, ref tikv#6200

1. role can be transfer when their's rule role is same.

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: bufferflies <1045931706@qq.com>
Co-authored-by: lhy1024 <admin@liudos.us>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
CabinfeverB pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 22, 2023
@ti-chi-bot @bufferflies
@lhy1024 @CabinfeverB
rule: it can transfer leader between the different rule (tikv#6200) (t…
d23aa87 
…ikv#6203)

close tikv#6195, ref tikv#6200

1. role can be transfer when their's rule role is same.

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: bufferflies <1045931706@qq.com>
Co-authored-by: lhy1024 <admin@liudos.us>
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
ti-chi-bot added a commit that referenced this pull request Mar 23, 2023
@ti-chi-bot @bufferflies
rule: it can transfer leader between the different rule (#6200) (#6202)
7910e2c 
close #6195, ref #6200

1. role can be transfer when their's rule role is same.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: buffer <1045931706@qq.com>
Co-authored-by: bufferflies <1045931706@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.0 release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pd leader is not balance when dr-auto-sync is enabled
5 participants
@bufferflies @ti-chi-bot @CabinfeverB @nolouch @rleungx