-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fit: further optimize the selection of witness rule candidates #6148
Conversation
ref tikv#5568 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6148 +/- ##
==========================================
- Coverage 75.00% 74.48% -0.52%
==========================================
Files 404 391 -13
Lines 39015 38184 -831
==========================================
- Hits 29262 28441 -821
- Misses 7202 7231 +29
+ Partials 2551 2512 -39
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 93 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 3458660
|
@nathan-edgar: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref #5568
What problem does this PR solve?
Issue Number: Close #5568
What is changed and how does it work?
Adding witnessScore makes the witness relatively more balanced when fit rule.
master
With witnessScore
Check List
Tests
Code changes
Side effects
Related changes
Release note