Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fit: further optimize the selection of witness rule candidates #6148

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

ethercflow
Copy link
Member

ref #5568

What problem does this PR solve?

Issue Number: Close #5568

What is changed and how does it work?

Adding witnessScore makes the witness relatively more balanced when fit rule.

master
image

With witnessScore
image

fit: further optimize the selection of witness rule candidates

Check List

Tests

  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

None.

ref tikv#5568

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 12, 2023
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.52 ⚠️

Comparison is base (fe22771) 75.00% compared to head (3458660) 74.48%.

❗ Current head 3458660 differs from pull request most recent head 6f5223d. Consider uploading reports for the commit 6f5223d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6148      +/-   ##
==========================================
- Coverage   75.00%   74.48%   -0.52%     
==========================================
  Files         404      391      -13     
  Lines       39015    38184     -831     
==========================================
- Hits        29262    28441     -821     
- Misses       7202     7231      +29     
+ Partials     2551     2512      -39     
Flag Coverage Δ
unittests 74.48% <60.00%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/schedule/placement/fit.go 95.90% <60.00%> (-2.30%) ⬇️

... and 93 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 29, 2023
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3458660

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 29, 2023
@ti-chi-bot
Copy link
Member

@nathan-edgar: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c4a8b80 into tikv:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify placement rule to support witness
4 participants