Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST for tso microservice #6084

Merged
merged 25 commits into from
Mar 9, 2023
Merged

Add REST for tso microservice #6084

merged 25 commits into from
Mar 9, 2023

Conversation

hnes
Copy link
Contributor

@hnes hnes commented Mar 2, 2023

What problem does this PR solve?

Issue Number: ref #5836

What is changed and how does it work?

Add REST into tso microservice

Check List

Release note

None.

Signed-off-by: Sen Han <00hnes@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 2, 2023
@ti-chi-bot ti-chi-bot requested a review from HunDunDM March 2, 2023 14:28
@ti-chi-bot ti-chi-bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Mar 2, 2023
@ti-chi-bot ti-chi-bot requested a review from nolouch March 2, 2023 14:28
@ti-chi-bot
Copy link
Member

Hi @hnes. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hnes hnes changed the title Add REST into tso microservice Add REST for tso microservice Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 86.41% and project coverage change: -0.11 ⚠️

Comparison is base (55bb91a) 74.12% compared to head (dcdab04) 74.01%.

❗ Current head dcdab04 differs from pull request most recent head cefe7f0. Consider uploading reports for the commit cefe7f0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6084      +/-   ##
==========================================
- Coverage   74.12%   74.01%   -0.11%     
==========================================
  Files         385      388       +3     
  Lines       37970    38019      +49     
==========================================
- Hits        28144    28139       -5     
- Misses       7355     7388      +33     
- Partials     2471     2492      +21     
Flag Coverage Δ
unittests 74.01% <86.41%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/api/admin.go 61.76% <ø> (-5.95%) ⬇️
server/handler.go 52.78% <0.00%> (ø)
server/server.go 74.23% <ø> (-0.13%) ⬇️
pkg/mcs/tso/server/handler.go 63.63% <63.63%> (ø)
pkg/mcs/tso/server/server.go 45.66% <80.00%> (+0.39%) ⬆️
pkg/tso/admin.go 83.87% <83.87%> (ø)
pkg/mcs/resource_manager/server/server.go 54.50% <100.00%> (+0.20%) ⬆️
pkg/mcs/tso/server/apis/v1/api.go 100.00% <100.00%> (ø)
pkg/member/participant.go 32.88% <100.00%> (+0.45%) ⬆️
server/api/router.go 97.96% <100.00%> (+<0.01%) ⬆️
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

pkg/mcs/tso/server/apis/v1/api.go Outdated Show resolved Hide resolved
pkg/mcs/tso/server/apis/v1/api.go Outdated Show resolved Hide resolved
pkg/mcs/tso/server/apis/v1/api.go Outdated Show resolved Hide resolved
pkg/mcs/tso/server/apis/v1/api.go Outdated Show resolved Hide resolved
Signed-off-by: Sen Han <00hnes@gmail.com>
hnes added 5 commits March 6, 2023 12:33
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
@hnes hnes marked this pull request as ready for review March 7, 2023 08:29
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2023
hnes added 2 commits March 7, 2023 16:31
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
pkg/mcs/tso/server/apis/v1/api.go Outdated Show resolved Hide resolved
pkg/mcs/tso/server/apis/v1/api.go Outdated Show resolved Hide resolved
cmd/pd-server/main.go Outdated Show resolved Hide resolved
pkg/mcs/tso/server/apis/v1/api.go Outdated Show resolved Hide resolved
@rleungx
Copy link
Member

rleungx commented Mar 7, 2023

How about adding some tests in tests/mcs?

hnes added 4 commits March 7, 2023 16:40
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@ti-chi-bot
Copy link
Member

@binshi-bing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 8, 2023
@nolouch
Copy link
Contributor

nolouch commented Mar 8, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d716284

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 8, 2023
ti-chi-bot and others added 2 commits March 8, 2023 17:31
Signed-off-by: Sen Han <00hnes@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 8, 2023
@hnes
Copy link
Contributor Author

hnes commented Mar 8, 2023

/merge

@ti-chi-bot
Copy link
Member

@hnes: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hnes: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx
Copy link
Member

rleungx commented Mar 9, 2023

/rebuild

@rleungx
Copy link
Member

rleungx commented Mar 9, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dcdab04

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2023
@rleungx
Copy link
Member

rleungx commented Mar 9, 2023

/rebuild

@purelind
Copy link
Contributor

purelind commented Mar 9, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit feaad04 into tikv:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants