Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: write RU model config into the storage #6041

Merged
merged 5 commits into from
Feb 27, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #6038.

What is changed and how does it work?

- Introduce the RU model config.
- Write the RU model config into the storage while initializing the resource manager.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 74.84% // Head: 74.98% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (36a05e8) compared to base (10eeab1).
Patch coverage: 74.19% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6041      +/-   ##
==========================================
+ Coverage   74.84%   74.98%   +0.13%     
==========================================
  Files         368      368              
  Lines       36642    36661      +19     
==========================================
+ Hits        27425    27489      +64     
+ Misses       6816     6782      -34     
+ Partials     2401     2390      -11     
Flag Coverage Δ
unittests 74.98% <74.19%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/resource_group/controller/config.go 37.50% <0.00%> (ø)
client/resource_group/controller/controller.go 61.61% <ø> (ø)
pkg/storage/endpoint/key_path.go 94.82% <ø> (ø)
pkg/mcs/resource_manager/server/config.go 15.27% <62.50%> (+13.58%) ⬆️
pkg/mcs/resource_manager/server/manager.go 80.76% <83.33%> (+0.24%) ⬆️
pkg/mcs/resource_manager/server/grpc_service.go 68.60% <100.00%> (ø)
pkg/mcs/resource_manager/server/install/install.go 100.00% <100.00%> (ø)
pkg/mcs/resource_manager/server/server.go 48.76% <100.00%> (+0.31%) ⬆️
pkg/storage/endpoint/resource_group.go 85.71% <100.00%> (+2.38%) ⬆️
server/config/config.go 75.87% <100.00%> (+0.05%) ⬆️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/mcs/resource_manager/server/config.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2023
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@HuSharp: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 27, 2023
@nolouch
Copy link
Contributor

nolouch commented Feb 27, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 60ad71c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 27, 2023
@ti-chi-bot ti-chi-bot merged commit 8d4438e into tikv:master Feb 27, 2023
@JmPotato JmPotato deleted the configurable_ru_model branch February 27, 2023 09:18
ti-chi-bot pushed a commit that referenced this pull request Mar 1, 2023
…alizing controller (#6048)

ref #6038, ref #6041

- Load RU config from the remote server when initializing controller.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this pull request Apr 19, 2023
ref tikv#6038

- Introduce the RU model config.
- Write the RU model config into the storage while initializing the resource manager.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/resource-control release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants