Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: move client function to util #5964

Merged
merged 4 commits into from
Feb 13, 2023
Merged

server: move client function to util #5964

merged 4 commits into from
Feb 13, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Feb 10, 2023

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Issue Number: Close #5837

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

 None.

@lhy1024 lhy1024 requested a review from rleungx February 10, 2023 17:47
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 10, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 10, 2023

cc @rleungx @binshi-bing

@codecov
Copy link

codecov bot commented Feb 10, 2023 •
edited
Loading

Codecov Report

Base: 75.22% // Head: 75.14% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (75e5f1f) compared to base (5a8f93d).
Patch coverage: 38.18% of modified lines in pull request are covered.

❗ Current head 75e5f1f differs from pull request most recent head 94db584. Consider uploading reports for the commit 94db584 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5964      +/-   ##
==========================================
- Coverage   75.22%   75.14%   -0.08%     
==========================================
  Files         362      362              
  Lines       36232    36270      +38     
==========================================
  Hits        27255    27255              
- Misses       6601     6642      +41     
+ Partials     2376     2373       -3
Flag Coverage Δ
unittests 75.14% <38.18%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/util.go 50.00% <0.00%> (-36.67%) ⬇️
server/config/config.go 73.77% <33.33%> (-1.23%) ⬇️
pkg/utils/etcdutil/etcdutil.go 88.34% <88.23%> (+3.46%) ⬆️
server/server.go 75.51% <100.00%> (+0.63%) ⬆️
pkg/tso/local_allocator.go 62.16% <0.00%> (-13.52%) ⬇️
pkg/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
pkg/election/leadership.go 75.25% <0.00%> (-5.16%) ⬇️
pkg/tso/allocator_manager.go 61.61% <0.00%> (-4.36%) ⬇️
server/schedulers/shuffle_hot_region.go 56.66% <0.00%> (-3.34%) ⬇️
pkg/member/member.go 64.21% <0.00%> (-3.16%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rleungx rleungx mentioned this pull request Feb 13, 2023
Merged
@lhy1024
use tikv#5971 and move client
53eedb5 
Signed-off-by: lhy1024 <admin@liudos.us>
rleungx
rleungx approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM, please also change the PR title.

pkg/utils/etcdutil/etcdutil.go Outdated
@@ -36,6 +36,9 @@ import (
)

const (
// DefaultEtcdClientTimeout is the default timeout for etcd client.
DefaultEtcdClientTimeout = 3 * time.Second
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to expose it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether is used by other servers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once it will be used, we can expose it then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@lhy1024 lhy1024 changed the title server: add service mode param and move client server: move client function to util Feb 13, 2023
@lhy1024
address comments
6ab4d71 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2023
@rleungx
Copy link
Member

rleungx commented Feb 13, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6ab4d71

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2023
@ti-chi-bot ti-chi-bot merged commit 0ed822c into tikv:master Feb 13, 2023
ti-chi-bot added a commit that referenced this pull request Feb 15, 2023
@rleungx @ti-chi-bot @lhy1024
*: add service subcommand (#5971)
f1e3bf5 
ref #5836, ref #5964

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: lhy1024 <admin@liudos.us>
This was referenced Feb 22, 2023
Closed
Closed
nolouch pushed a commit to nolouch/pd that referenced this pull request Feb 24, 2023
@rleungx @ti-chi-bot
@lhy1024 @nolouch
*: add service subcommand (tikv#5971)
ba530aa 
ref tikv#5836, ref tikv#5964

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: lhy1024 <admin@liudos.us>
nolouch pushed a commit to nolouch/pd that referenced this pull request Feb 24, 2023
@lhy1024 @ti-chi-bot @nolouch
server: move client function to util (tikv#5964)
e853333 
close tikv#5837

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
nolouch pushed a commit to nolouch/pd that referenced this pull request Feb 24, 2023
@lhy1024 @nolouch
server: move client function to util (tikv#5964)
27c8f9f 
close tikv#5837

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Conflicts:
	pkg/utils/etcdutil/etcdutil.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the service start with independent mode
4 participants
@lhy1024 @ti-chi-bot @rleungx @HunDunDM