-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
region_scatterer: fix the bug that could generate schedule with too many peers #5920
Conversation
…any peers Signed-off-by: HunDunDM <hundundm@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 75.43% // Head: 75.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5920 +/- ##
==========================================
- Coverage 75.43% 75.42% -0.01%
==========================================
Files 345 345
Lines 35126 35127 +1
==========================================
Hits 26496 26496
- Misses 6330 6334 +4
+ Partials 2300 2297 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 40521b7
|
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: Close #5909
What is changed and how does it work?
Introduced in #4570 , used stores were not excluded resulting in possible selection of too many
targeterPeers
.Check List
Tests
Code changes
Side effects
Related changes
Release note