Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyspace: Pre alloc keyspace #5869

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Conversation

AmoebaProtozoa
Copy link
Contributor

@AmoebaProtozoa AmoebaProtozoa commented Jan 16, 2023

What problem does this PR solve?

Issue Number: Ref #5293

Addes config

[keyspaces]
pre-alloc = ["admin", "user1", "user2"]

to support pre-allocation of keyspace at pd bootstrap. With this, user can conveniently create a multi-tenant tidb cluster via tiup, instead of bootstrapping a pd cluster first and create keyspaces with http request before starting tidb.

What is changed and how does it work?

Check List

Tests

  • Manual test

Release note

None.

Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jan 16, 2023
@ti-chi-bot
Copy link
Member

Hi @AmoebaProtozoa. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AmoebaProtozoa AmoebaProtozoa mentioned this pull request Jan 16, 2023
11 tasks
@AmoebaProtozoa AmoebaProtozoa marked this pull request as ready for review January 16, 2023 05:58
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2023
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 75.61% // Head: 75.35% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (5d759b7) compared to base (fda03e5).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5869      +/-   ##
==========================================
- Coverage   75.61%   75.35%   -0.26%     
==========================================
  Files         337      337              
  Lines       34134    34143       +9     
==========================================
- Hits        25809    25730      -79     
- Misses       6114     6199      +85     
- Partials     2211     2214       +3     
Flag Coverage Δ
unittests 75.35% <80.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 78.71% <ø> (ø)
server/keyspace/keyspace.go 69.36% <77.77%> (+0.33%) ⬆️
server/server.go 75.00% <100.00%> (ø)
pkg/dashboard/keyvisual/input/core.go 0.00% <0.00%> (-33.34%) ⬇️
server/api/diagnostic.go 76.92% <0.00%> (-23.08%) ⬇️
pkg/id/id.go 83.05% <0.00%> (-6.78%) ⬇️
server/tso/local_allocator.go 62.16% <0.00%> (-6.76%) ⬇️
server/tso/allocator_manager.go 58.70% <0.00%> (-5.00%) ⬇️
pkg/storage/endpoint/meta.go 63.63% <0.00%> (-4.55%) ⬇️
server/region_syncer/server.go 82.96% <0.00%> (-4.40%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2023
@ti-chi-bot
Copy link
Member

@ystaticy: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 17, 2023
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5d759b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2023
@HuSharp
Copy link
Member

HuSharp commented Jan 17, 2023

/test build

@ti-chi-bot
Copy link
Member

@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rleungx
Copy link
Member

rleungx commented Jan 17, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jan 17, 2023
@ti-chi-bot ti-chi-bot merged commit 7ea589e into tikv:master Jan 17, 2023
@AmoebaProtozoa AmoebaProtozoa deleted the pre-alloc-keyspace branch January 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants