-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keyspace: Pre alloc keyspace #5869
Conversation
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @AmoebaProtozoa. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportBase: 75.61% // Head: 75.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5869 +/- ##
==========================================
- Coverage 75.61% 75.35% -0.26%
==========================================
Files 337 337
Lines 34134 34143 +9
==========================================
- Hits 25809 25730 -79
- Misses 6114 6199 +85
- Partials 2211 2214 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
da7cf37
to
1598d99
Compare
@ystaticy: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 5d759b7
|
/test build |
@HuSharp: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
What problem does this PR solve?
Issue Number: Ref #5293
Addes config
to support pre-allocation of keyspace at pd bootstrap. With this, user can conveniently create a multi-tenant tidb cluster via tiup, instead of bootstrapping a pd cluster first and create keyspaces with http request before starting tidb.
What is changed and how does it work?
Check List
Tests
Release note