Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: when Region is removed from RegionsInfo, also remove fit cache #5865

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

HunDunDM
Copy link
Member

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

Issue Number: Ref #5864

When a Region is deleted from RegionsInfo for reasons such as Merge, its FitCache will remain in memory forever, resulting in a memory leak.

What is changed and how does it work?

part of #5860

Remove the Fit Cache when removing the overlaps region.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 75.55% // Head: 75.55% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (94a0daa) compared to base (c5bf5be).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 94a0daa differs from pull request most recent head 33be395. Consider uploading reports for the commit 33be395 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5865    +/-   ##
========================================
  Coverage   75.55%   75.55%            
========================================
  Files         341      337     -4     
  Lines       34404    34155   -249     
========================================
- Hits        25993    25805   -188     
+ Misses       6178     6127    -51     
+ Partials     2233     2223    -10     
Flag Coverage Δ
unittests 75.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/cluster/cluster.go 81.76% <100.00%> (-0.50%) ⬇️
server/schedule/placement/rule_manager.go 85.20% <100.00%> (+0.89%) ⬆️
pkg/mcs/resource_manager/server/grpc_service.go 73.91% <0.00%> (-5.82%) ⬇️
server/tso/tso.go 68.53% <0.00%> (-5.62%) ⬇️
pkg/member/member.go 62.10% <0.00%> (-3.69%) ⬇️
pkg/utils/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
pkg/id/id.go 83.05% <0.00%> (-3.39%) ⬇️
client/client.go 67.59% <0.00%> (-3.20%) ⬇️
pkg/storage/kv/etcd_kv.go 72.22% <0.00%> (-3.18%) ⬇️
server/schedulers/transfer_witness_leader.go 78.26% <0.00%> (-3.14%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 19, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 19, 2023
@HunDunDM
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 33be395

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 19, 2023
@ti-chi-bot ti-chi-bot merged commit 6e35a4d into tikv:master Jan 19, 2023
@HunDunDM HunDunDM deleted the remove-overlaps-cache branch January 19, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants