Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: unify the keyspace naming #5863

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Issue Number: ref #5293.

What is changed and how does it work?

Unify the keyspace naming.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 13, 2023
@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 13, 2023
@JmPotato JmPotato removed the request for review from Yisaer January 13, 2023 07:44
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 74.91% // Head: 75.58% // Increases project coverage by +0.67% 🎉

Coverage data is based on head (cbf0853) compared to base (364a1e1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5863      +/-   ##
==========================================
+ Coverage   74.91%   75.58%   +0.67%     
==========================================
  Files         335      337       +2     
  Lines       34094    34146      +52     
==========================================
+ Hits        25540    25809     +269     
+ Misses       6359     6116     -243     
- Partials     2195     2221      +26     
Flag Coverage Δ
unittests 75.58% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/storage.go 71.15% <ø> (ø)
pkg/storage/endpoint/gc_key_space.go 66.66% <100.00%> (ø)
pkg/storage/endpoint/key_path.go 93.18% <100.00%> (+2.27%) ⬆️
pkg/utils/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
pkg/dashboard/adapter/manager.go 74.71% <0.00%> (-6.90%) ⬇️
pkg/storage/kv/etcd_kv.go 72.22% <0.00%> (-3.18%) ⬇️
pkg/election/leadership.go 77.31% <0.00%> (-3.10%) ⬇️
server/tso/tso.go 68.53% <0.00%> (-2.81%) ⬇️
server/schedulers/shuffle_hot_region.go 55.12% <0.00%> (-2.57%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 13, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cbf0853

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2023
@ti-chi-bot ti-chi-bot merged commit 0f75293 into tikv:master Jan 13, 2023
@JmPotato JmPotato deleted the unify_keyspace_naming branch January 13, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants