-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: move core to pkg #5781
*: move core to pkg #5781
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 74.96% // Head: 74.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5781 +/- ##
==========================================
- Coverage 74.96% 74.95% -0.02%
==========================================
Files 337 335 -2
Lines 34065 34030 -35
==========================================
- Hits 25536 25506 -30
+ Misses 6341 6337 -4
+ Partials 2188 2187 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the core package need to provided to the third party?
Do you mean to use an individual mod? |
Noop, just suspect really need to move? |
I think these definitions will be shared by multiple services so that moving them out will be more clear. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: bc2e9ce
|
reviewed |
Signed-off-by: Ryan Leung rleungx@gmail.com
What problem does this PR solve?
Issue Number: Ref #5838.
What is changed and how does it work?
This PR does the following things:
core
fromserver
topkg
Check List
Tests
Release note