-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: fix ToHotPeersStat
result when HotPeers
is empty
#5597
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 75.67% // Head: 75.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5597 +/- ##
==========================================
- Coverage 75.67% 75.52% -0.15%
==========================================
Files 326 326
Lines 32370 32370
==========================================
- Hits 24495 24449 -46
- Misses 5767 5809 +42
- Partials 2108 2112 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, need a test
Signed-off-by: lhy1024 <admin@liudos.us>
4b08bdb
to
1492d38
Compare
Signed-off-by: lhy1024 <admin@liudos.us>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: b284cf2
|
In response to a cherrypick label: new pull request created: #5617. |
close tikv#5598 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5618. |
close tikv#5598 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5619. |
In response to a cherrypick label: new pull request created: #5620. |
close tikv#5598 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
close tikv#5598 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5621. |
Signed-off-by: lhy1024 admin@liudos.us
What problem does this PR solve?
Issue Number: Close #5598
What is changed and how does it work?
Check List
Tests
Release note