Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix Stream timeout logic (#5551) #5583

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5551

Signed-off-by: Cabinfever_B cabinfeveroier@gmail.com

What problem does this PR solve?

Issue Number: Close #5207

What is changed and how does it work?

fix Stream timeout logic

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

After the leader recovers the service, the interval of client tso service recovery is tested. Compared with the previous worst-case recovery time of 23 seconds, the current recovery time can be controlled within one second
before
image
This PR
image

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

close tikv#5207

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick. do-not-merge/cherry-pick-not-approved labels Oct 10, 2022
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2022
@nolouch
Copy link
Contributor

nolouch commented Nov 1, 2022

lint failed.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 1, 2022
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@CabinfeverB
Copy link
Member

/run-all-tests

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 75.07% // Head: 74.91% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (81850fe) compared to base (a66761b).
Patch coverage: 63.15% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-5.3    #5583      +/-   ##
===============================================
- Coverage        75.07%   74.91%   -0.16%     
===============================================
  Files              263      263              
  Lines            27361    27364       +3     
===============================================
- Hits             20540    20500      -40     
- Misses            5014     5044      +30     
- Partials          1807     1820      +13     
Flag Coverage Δ
unittests 74.91% <63.15%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/client.go 71.88% <63.15%> (-0.25%) ⬇️
pkg/cache/lru.go 79.06% <0.00%> (-9.31%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
server/region_syncer/server.go 84.55% <0.00%> (-5.89%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-3.20%) ⬇️
server/server.go 70.79% <0.00%> (-1.48%) ⬇️
server/member/member.go 65.24% <0.00%> (-1.07%) ⬇️
server/grpc_service.go 50.20% <0.00%> (-0.92%) ⬇️
server/core/storage.go 68.79% <0.00%> (-0.76%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nolouch
Copy link
Contributor

nolouch commented Nov 1, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 81850fe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2022
@ti-chi-bot ti-chi-bot merged commit bb3953a into tikv:release-5.3 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants