Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix the table compatibility problem #5428

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 12, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5396.

What is changed and how does it work?

Check List

Tests

  • Manual test

Release note

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the component/metrics Metrics. label Aug 12, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #5428 (b1fd975) into master (ab01355) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5428      +/-   ##
==========================================
- Coverage   75.65%   75.61%   -0.05%     
==========================================
  Files         313      313              
  Lines       31130    31130              
==========================================
- Hits        23552    23538      -14     
- Misses       5566     5578      +12     
- Partials     2012     2014       +2     
Flag Coverage Δ
unittests 75.61% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dashboard/keyvisual/input/core.go 0.00% <0.00%> (-33.34%) ⬇️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/schedulers/shuffle_hot_region.go 53.53% <0.00%> (-12.13%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-4.06%) ⬇️
server/schedulers/random_merge.go 61.29% <0.00%> (-3.23%) ⬇️
server/tso/tso.go 70.62% <0.00%> (-2.26%) ⬇️
server/region_syncer/client.go 85.82% <0.00%> (-2.24%) ⬇️
server/election/lease.go 84.05% <0.00%> (-1.45%) ⬇️
server/storage/hot_region_storage.go 78.14% <0.00%> (-1.10%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bufferflies
Copy link
Contributor

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2022

Visit the grafana server at: http://172.16.5.21:30420, it will last for 5 hours

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2022
@nolouch
Copy link
Contributor

nolouch commented Aug 12, 2022

How the grafana looks like?

@@ -1231,7 +1196,7 @@
"h": 7,
"w": 4,
"x": 0,
"y": 14
"y": 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change the position? I can not see any new monitor .

Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2022
@bufferflies
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b1fd975

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 15, 2022
@ti-chi-bot ti-chi-bot merged commit 750aada into tikv:master Aug 15, 2022
@rleungx rleungx deleted the fix-metrics1 branch August 15, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics Metrics. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants