-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv: added RunInTransaction style transaction interface #5347
Conversation
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Codecov ReportBase: 75.45% // Head: 75.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5347 +/- ##
==========================================
- Coverage 75.45% 75.34% -0.12%
==========================================
Files 338 338
Lines 33655 33774 +119
==========================================
+ Hits 25396 25448 +52
- Misses 6065 6126 +61
- Partials 2194 2200 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi, @AmoebaProtozoa , would you please resolve the conflicts, I think it's useful. |
# Conflicts: # pkg/storage/kv/etcd_kv.go # pkg/storage/kv/levedb_kv.go
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d60e299
|
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 5f7115e
|
/rebuild |
/test build |
What problem does this PR solve?
Issue Number: Ref #5293
Current
kv.Base
interface lacks the ability to run batch commands in transactions.In order to leverage transactions in
etcd
, one must get a hold ofetcd.Client
, bypassing the Storage and KV level abstractions.This PR aims to solve this by providing basic transaction abilities at the storage level.
What is changed and how does it work?
Check List
Tests
Release note