Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: partially fix grpc status (#4798) #5215

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 22, 2022

This is an automated cherry-pick of #4798

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #4797.

What is changed and how it works?

This PR removes unnecessary withStack and partially fix the above issue.

Check List

Tests

  • Unit test

Release note

Fix the issue that the status code of `not leader` is sometimes wrong 

ref tikv#4797

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 22, 2022
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick. label Jun 22, 2022
@ti-chi-bot ti-chi-bot requested review from HunDunDM and nolouch June 22, 2022 11:20
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 24, 2022
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the cherry-pick-4798-to-release-5.2 branch from 3a2bdd4 to 15789b9 Compare June 27, 2022 11:46
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #5215 (f53503f) into release-5.2 (e792849) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

@@               Coverage Diff               @@
##           release-5.2    #5215      +/-   ##
===============================================
- Coverage        74.93%   74.89%   -0.05%     
===============================================
  Files              249      249              
  Lines            25747    25747              
===============================================
- Hits             19294    19282      -12     
- Misses            4766     4774       +8     
- Partials          1687     1691       +4     
Flag Coverage Δ
unittests 74.89% <25.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/grpc_service.go 47.23% <25.00%> (ø)
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-3.20%) ⬇️
client/base_client.go 82.29% <0.00%> (-2.09%) ⬇️
server/schedule/operator_controller.go 83.56% <0.00%> (-1.99%) ⬇️
server/tso/allocator_manager.go 67.61% <0.00%> (-1.34%) ⬇️
server/tso/tso.go 67.21% <0.00%> (-1.10%) ⬇️
server/config/persist_options.go 91.53% <0.00%> (-0.77%) ⬇️
server/cluster/coordinator.go 72.25% <0.00%> (-0.68%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e792849...f53503f. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 5, 2022
@rleungx
Copy link
Member

rleungx commented Jul 5, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f53503f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2022
@ti-chi-bot ti-chi-bot merged commit 6853e8f into tikv:release-5.2 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants