-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add support for tiflash_mpp label/tiflash ReadNode #4928
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
/run-all-tests |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…nto support_tiflash_readnode
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…node Signed-off-by: guo-shaoge <shaoge1994@163.com>
/run-all-tests |
1 similar comment
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some tests?
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…nto support_tiflash_readnode
Sorry for the late reply. The following cases are added:
I'm writing more complicated cases using test-infra. |
@guo-shaoge: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: guo-shaoge shaoge1994@163.com
What problem does this PR solve?
Issue Number: Close #4836
What is changed and how does it work?
Make PD be compatible with new tiflash_mpp label(<engine, tiflash_mpp>).
Check List
Tests
N/A
Code changes
N/A
Side effects
N/A
Related changes
N/A
Release note