Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add support for tiflash_mpp label/tiflash ReadNode #4928

Closed
wants to merge 12 commits into from

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented May 12, 2022

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: Close #4836

What is changed and how does it work?

*: add support for tiflash_mpp label/tiflash ReadNode

Make PD be compatible with new tiflash_mpp label(<engine, tiflash_mpp>).

Check List

Tests

N/A

Code changes

N/A

Side effects

N/A

Related changes

N/A

Release note

None

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 12, 2022
@ti-chi-bot ti-chi-bot requested review from JmPotato and nolouch May 12, 2022 03:59
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 12, 2022
@guo-shaoge
Copy link
Contributor Author

/run-all-tests

Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…node

Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Copy link
Contributor Author

/run-all-tests

1 similar comment
@guo-shaoge
Copy link
Contributor Author

/run-all-tests

@guo-shaoge guo-shaoge requested review from JmPotato and rleungx May 16, 2022 02:47
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 16, 2022
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests?

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Copy link
Contributor Author

Could you add some tests?

Sorry for the late reply. The following cases are added:

  1. testHotWriteRegionSchedulerSuite.TestWithTiFlashMPP: test hot_region_scheduler with tiflash_mpp nodes.
  2. testClusterInfoSuite.TestEngineLabel: test if engine label is correct when PutStore
  3. testClusterInfoSuite.TestRegionLabelIsolationLevel: isolation level of tiflash/tiflash_mpp will be ignored(see updateRegionsLabelLevelStats())

I'm writing more complicated cases using test-infra.

@guo-shaoge guo-shaoge requested a review from nolouch May 18, 2022 10:58
@ti-chi-bot
Copy link
Member

@guo-shaoge: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2022
@guo-shaoge guo-shaoge closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Decouping of Compute and Storage of TiFlash
5 participants