-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix duplicate panel id & Invalid data sources #4312
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@buggithubs Please update the commit message. |
close tikv#4314 Signed-off-by: buggithubs <jeff.true.time@gmail.com>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c642b9f
|
@buggithubs: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #4312 +/- ##
==========================================
- Coverage 74.92% 74.90% -0.03%
==========================================
Files 264 264
Lines 27272 27272
==========================================
- Hits 20434 20427 -7
- Misses 5025 5035 +10
+ Partials 1813 1810 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
In response to a cherrypick label: new pull request created: #4318. |
In response to a cherrypick label: new pull request created: #4319. |
What problem does this PR solve?
Close #4314.
What is changed and how it works?
Current ID allocation & scatter operator event
duplicate panel idCurrent ID allocation
Invalid data sourcesCheck List
Tests
Code changes
Side effects
Related changes
Release note