Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate panel id & Invalid data sources #4312

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

buggithubs
Copy link
Collaborator

@buggithubs buggithubs commented Nov 10, 2021

What problem does this PR solve?

Close #4314.

What is changed and how it works?

Current ID allocation & scatter operator event duplicate panel id
Current ID allocation Invalid data sources

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-commit-message release-note-none Denotes a PR that doesn't merit a release note. labels Nov 10, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2021
@rleungx
Copy link
Member

rleungx commented Nov 10, 2021

@buggithubs Please update the commit message.

@rleungx rleungx added needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 labels Nov 10, 2021
close tikv#4314

Signed-off-by: buggithubs <jeff.true.time@gmail.com>
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c642b9f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2021
@ti-chi-bot
Copy link
Member

@buggithubs: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato
Copy link
Member

/run-unit-test

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #4312 (f29b788) into master (71ec276) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4312      +/-   ##
==========================================
- Coverage   74.92%   74.90%   -0.03%     
==========================================
  Files         264      264              
  Lines       27272    27272              
==========================================
- Hits        20434    20427       -7     
- Misses       5025     5035      +10     
+ Partials     1813     1810       -3     
Flag Coverage Δ
unittests 74.90% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
server/region_syncer/client.go 78.90% <0.00%> (-4.69%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/schedule/operator_controller.go 82.68% <0.00%> (-2.04%) ⬇️
server/tso/allocator_manager.go 65.00% <0.00%> (-1.17%) ⬇️
server/config/persist_options.go 91.66% <0.00%> (-0.76%) ⬇️
server/schedule/operator/step.go 72.32% <0.00%> (-0.74%) ⬇️
server/server.go 71.55% <0.00%> (+0.29%) ⬆️
server/grpc_service.go 50.60% <0.00%> (+0.70%) ⬆️
server/member/member.go 65.24% <0.00%> (+2.13%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ec276...f29b788. Read the comment docs.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4318.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4319.

ti-chi-bot added a commit that referenced this pull request Nov 16, 2021
close #4314

Signed-off-by: buggithubs <jeff.true.time@gmail.com>

Co-authored-by: buggithubs <jeff.true.time@gmail.com>
ti-chi-bot added a commit that referenced this pull request Nov 30, 2021
close #4314

Signed-off-by: buggithubs <jeff.true.time@gmail.com>

Co-authored-by: buggithubs <jeff.true.time@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PD & Grafana dashboard duplicate panel ids exist
5 participants