Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard to v2021.10.08.1 #4189

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Oct 8, 2021

Signed-off-by: baurine 2008.hbl@gmail.com

What problem does this PR solve?

Update tidb-dashboard to v2021.10.08.1 (dashboard side fix a silly error about checking the user privileges in PR: pingcap/tidb-dashboard#1018)

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

Update tidb-dashboard to v2021.10.08.1

Signed-off-by: baurine <2008.hbl@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #4189 (532375b) into master (78b363c) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4189      +/-   ##
==========================================
+ Coverage   74.66%   74.76%   +0.09%     
==========================================
  Files         260      260              
  Lines       26487    26487              
==========================================
+ Hits        19776    19802      +26     
+ Misses       4928     4909      -19     
+ Partials     1783     1776       -7     
Flag Coverage Δ
unittests 74.76% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
client/base_client.go 81.52% <0.00%> (-2.18%) ⬇️
server/member/member.go 64.70% <0.00%> (-2.14%) ⬇️
server/election/lease.go 86.15% <0.00%> (-1.54%) ⬇️
server/tso/global_allocator.go 60.84% <0.00%> (-1.06%) ⬇️
server/encryptionkm/key_manager.go 72.80% <0.00%> (-0.80%) ⬇️
server/core/storage.go 68.04% <0.00%> (-0.76%) ⬇️
server/cluster/cluster.go 82.33% <0.00%> (-0.48%) ⬇️
server/server.go 72.60% <0.00%> (-0.45%) ⬇️
client/client.go 72.08% <0.00%> (+0.41%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b363c...532375b. Read the comment docs.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2021
@JmPotato
Copy link
Member

JmPotato commented Oct 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 532375b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2021
@ti-chi-bot ti-chi-bot merged commit c13b76a into tikv:master Oct 8, 2021
@baurine baurine deleted the update-dashboard-1008 branch October 8, 2021 08:31
hzh0425 pushed a commit to hzh0425/pd that referenced this pull request Nov 16, 2021
Signed-off-by: baurine <2008.hbl@gmail.com>
Signed-off-by: hzh0425 <642256541@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants