schedule: not limit remove peer of the down store (#4097)

[ti-chi-bot]

This is an automated cherry-pick of #4097

What problem does this PR solve?

Close #4090.

What is changed and how it works?

This PR adds a flag in the remove peer step to let the store limit not work when the remove store is down.

Check List

Tests

• Unit test

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• bufferflies
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[disksing]

need resolve conflict

[nolouch]

lgtm

[bufferflies]

lgtm

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: a979ab6

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[rleungx]

/run-unit-tests

[nolouch]

/run-unit-tests

[nolouch]

/run-unit-tests

[nolouch]

/run-unit-tests

[codecov]

Codecov Report

Merging #4114 (508364e) into release-5.0 (a4a4c5a) will decrease coverage by 0.07%.
The diff coverage is 62.96%.

@@               Coverage Diff               @@
##           release-5.0    #4114      +/-   ##
===============================================
- Coverage        74.87%   74.79%   -0.08%     
===============================================
  Files              245      245              
  Lines            24336    24356      +20     
===============================================
- Hits             18221    18218       -3     
- Misses            4504     4521      +17     
- Partials          1611     1617       +6     

Flag	Coverage Δ
unittests	74.79% <62.96%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedule/region_scatterer.go	81.61% <0.00%> (-6.87%)	⬇️
server/schedule/checker/replica_strategy.go	88.37% <50.00%> (-4.13%)	⬇️
server/schedulers/shuffle_region.go	75.67% <50.00%> (-1.79%)	⬇️
server/schedule/checker_controller.go	68.29% <100.00%> (+0.79%)	⬆️
server/schedule/operator/builder.go	88.10% <100.00%> (+0.12%)	⬆️
server/schedule/operator/influence.go	85.71% <100.00%> (ø)
server/schedule/operator/step.go	67.65% <100.00%> (+0.21%)	⬆️
server/statistics/store.go	90.67% <100.00%> (ø)
server/schedulers/shuffle_hot_region.go	55.10% <0.00%> (-10.21%)	⬇️
server/member/member.go	63.04% <0.00%> (-6.53%)	⬇️
... and 15 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcecc89...508364e. Read the comment docs.