Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: return rules after clone (#3892) #3915

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3892

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Fix #3886

What is changed and how it works?

Clone the rule before returning to callers. It should be safe to modify and update again.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix an issue where data is not stored when using max-replicas or location-labels to indirectly update default placement rule

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick. labels Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #3915 (7e41a72) into release-5.1 (31aea9b) will decrease coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.1    #3915      +/-   ##
===============================================
- Coverage        75.14%   75.11%   -0.04%     
===============================================
  Files              245      245              
  Lines            24600    24614      +14     
===============================================
+ Hits             18486    18488       +2     
- Misses            4500     4510      +10     
- Partials          1614     1616       +2     
Flag Coverage Δ
unittests 75.11% <85.71%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/server.go 72.03% <50.00%> (+0.71%) ⬆️
pkg/typeutil/comparison.go 85.71% <60.00%> (-14.29%) ⬇️
server/schedule/placement/rule.go 96.15% <100.00%> (+0.40%) ⬆️
server/schedule/placement/rule_manager.go 83.13% <100.00%> (+0.25%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/tso/global_allocator.go 70.55% <0.00%> (-5.00%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/tso/allocator_manager.go 77.46% <0.00%> (-3.51%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-1.67%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31aea9b...7e41a72. Read the comment docs.

@HunDunDM HunDunDM modified the milestones: v5.1.1, v5.1.2 Jul 28, 2021
@disksing disksing removed their request for review August 24, 2021 03:08
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 13, 2021
@HunDunDM
Copy link
Member

/run-unit-test

@nolouch
Copy link
Contributor

nolouch commented Sep 13, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7e41a72

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2021
@ti-chi-bot ti-chi-bot merged commit 59693ab into tikv:release-5.1 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants