-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: one operator only occupy one limit (#3820) #3857
schedule: one operator only occupy one limit (#3820) #3857
Conversation
* use O(1) to get WMA Signed-off-by: tongjian <1045931706@qq.com> * add sonar file ignore code duplicated Signed-off-by: tongjian <1045931706@qq.com> Signed-off-by: buffer <1045931706@qq.com> * one operator should occupy one limit Signed-off-by: bufferflies <1045931706@qq.com> * remove no need change Signed-off-by: bufferflies <1045931706@qq.com> * move scheduler OpKind to operator.go Signed-off-by: bufferflies <1045931706@qq.com> * replace opkind to get op producer by using LowBit Signed-off-by: bufferflies <1045931706@qq.com> * pass uint test Signed-off-by: bufferflies <1045931706@qq.com> * replace chinese link Signed-off-by: bufferflies <1045931706@qq.com> * OperatorCount use O(1) Signed-off-by: bufferflies <1045931706@qq.com>
Codecov Report
@@ Coverage Diff @@
## release-5.1 #3857 +/- ##
===============================================
- Coverage 75.18% 75.02% -0.17%
===============================================
Files 245 245
Lines 24531 24538 +7
===============================================
- Hits 18444 18409 -35
- Misses 4474 4503 +29
- Partials 1613 1626 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d62537c
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This is an automated cherry-pick of #3820
Signed-off-by: tongjian 1045931706@qq.com
What problem does this PR solve?
fix: #3807
#3778
What is changed and how it works?
operator controller's count will occupy the highest priority OpKind even if the operator has many OpKind.
the relation between limit and scheduler is blow:
red mark need to be changed
Check List
Tests
Code changes
Side effects
Related changes
Release note