Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: simplify the limit judgment of hot-region-scheduler #3834

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Jul 5, 2021

Signed-off-by: HunDunDM hundundm@gmail.com

What problem does this PR solve?

related #3778
changes caused by #3820

What is changed and how it works?

OpLeader and LeaderScheduleLimit are no longer judged in balance-hot-region-scheduler.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

Signed-off-by: HunDunDM <hundundm@gmail.com>
@HunDunDM HunDunDM added component/scheduler Scheduler logic. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 labels Jul 5, 2021
@HunDunDM HunDunDM requested review from nolouch and lhy1024 July 5, 2021 13:33
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 5, 2021
@HunDunDM
Copy link
Member Author

HunDunDM commented Jul 5, 2021

/cc @bufferflies

@ti-chi-bot
Copy link
Member

@HunDunDM: GitHub didn't allow me to request PR reviews from the following users: bufferflies.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @bufferflies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: HunDunDM <hundundm@gmail.com>
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #3834 (8d3acfc) into master (4a0970c) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3834      +/-   ##
==========================================
- Coverage   75.14%   75.09%   -0.06%     
==========================================
  Files         246      246              
  Lines       24740    24723      -17     
==========================================
- Hits        18592    18565      -27     
- Misses       4523     4530       +7     
- Partials     1625     1628       +3     
Flag Coverage Δ
unittests 75.09% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/hot_region.go 84.16% <0.00%> (-0.72%) ⬇️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-25.00%) ⬇️
server/tso/local_allocator.go 80.55% <0.00%> (-9.73%) ⬇️
server/schedulers/shuffle_hot_region.go 54.73% <0.00%> (-9.48%) ⬇️
server/tso/global_allocator.go 70.55% <0.00%> (-5.00%) ⬇️
server/statistics/hot_cache_task.go 79.16% <0.00%> (-4.17%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
client/base_client.go 82.81% <0.00%> (-1.57%) ⬇️
server/member/member.go 68.81% <0.00%> (-1.08%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0970c...8d3acfc. Read the comment docs.

@bufferflies
Copy link
Contributor

lgtm

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2021
@nolouch
Copy link
Contributor

nolouch commented Jul 6, 2021

cc @lhy1024

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 7, 2021
@nolouch
Copy link
Contributor

nolouch commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 20690c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@github-actions github-actions bot removed needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 labels Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit c1f3128 into tikv:master Jul 8, 2021
@HunDunDM HunDunDM added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 labels Jul 9, 2021
@HunDunDM HunDunDM deleted the hot-region-limit branch July 9, 2021 06:16
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3853.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 9, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3854.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 9, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3855.

bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
…3834)

* scheduler: simplify the limit judgment of hot-region-scheduler

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix unit test

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Jul 16, 2021
Signed-off-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Jul 16, 2021
#3854)

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
ti-chi-bot added a commit that referenced this pull request Jul 23, 2021
#3853)

* scheduler: simplify the limit judgment of hot-region-scheduler

Signed-off-by: HunDunDM <hundundm@gmail.com>

* fix unit test

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
HunDunDM added a commit that referenced this pull request Aug 13, 2021
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Aug 13, 2021
ti-chi-bot added a commit that referenced this pull request Aug 14, 2021
#3855)

Signed-off-by: HunDunDM <hundundm@gmail.com>

Co-authored-by: HunDunDM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants