-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: simplify the limit judgment of hot-region-scheduler #3834
Conversation
Signed-off-by: HunDunDM <hundundm@gmail.com>
/cc @bufferflies |
@HunDunDM: GitHub didn't allow me to request PR reviews from the following users: bufferflies. Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: HunDunDM <hundundm@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3834 +/- ##
==========================================
- Coverage 75.14% 75.09% -0.06%
==========================================
Files 246 246
Lines 24740 24723 -17
==========================================
- Hits 18592 18565 -27
- Misses 4523 4530 +7
- Partials 1625 1628 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cc @lhy1024 |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 20690c3
|
In response to a cherrypick label: new pull request created: #3853. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #3854. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #3855. |
…3834) * scheduler: simplify the limit judgment of hot-region-scheduler Signed-off-by: HunDunDM <hundundm@gmail.com> * fix unit test Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: HunDunDM <hundundm@gmail.com>
#3854) Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>
#3853) * scheduler: simplify the limit judgment of hot-region-scheduler Signed-off-by: HunDunDM <hundundm@gmail.com> * fix unit test Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com>
Signed-off-by: HunDunDM <hundundm@gmail.com>
…3834) Signed-off-by: HunDunDM <hundundm@gmail.com>
#3855) Signed-off-by: HunDunDM <hundundm@gmail.com> Co-authored-by: HunDunDM <hundundm@gmail.com>
Signed-off-by: HunDunDM hundundm@gmail.com
What problem does this PR solve?
related #3778
changes caused by #3820
What is changed and how it works?
OpLeader
andLeaderScheduleLimit
are no longer judged inbalance-hot-region-scheduler
.Check List
Tests
Code changes
Side effects
Related changes
Release note