Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TiDB Dashboard to v2020.10.21.1 #3095

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Update TiDB Dashboard to v2020.10.21.1 #3095

merged 1 commit into from
Oct 22, 2020

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Oct 22, 2020 •
edited
Loading

What problem does this PR solve?

Update TiDB Dashboard to resolve a panic bug caused by KeyViz.

What is changed and how it works?

Update the TiDB Dashboard vendor to v2020.10.21.1

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

TiDB Dashboard: Fix a bug that KeyViz may panic

@breezewish
Update TiDB Dashboard to v2020.10.21.1
0c01674 
Signed-off-by: Breezewish <me@breeswish.org>
@HunDunDM HunDunDM self-requested a review October 22, 2020 07:36
HunDunDM
HunDunDM approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 22, 2020
Yisaer
Yisaer approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 22, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 22, 2020
@Yisaer
Copy link
Contributor

Yisaer commented Oct 22, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 22, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@HunDunDM HunDunDM added component/visualization Visualization. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. labels Oct 22, 2020
@ti-srebot ti-srebot merged commit d043072 into tikv:master Oct 22, 2020
ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Oct 22, 2020
@breezewish @ti-srebot
cherry pick tikv#3095 to release-4.0
5e74e3f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 22, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3096

ti-srebot added a commit that referenced this pull request Oct 22, 2020
@ti-srebot
Update TiDB Dashboard to v2020.10.21.1 (#3095) (#3096)
775b6a5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: Breezewish <me@breeswish.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@HunDunDM HunDunDM HunDunDM approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/visualization Visualization. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breezewish @Yisaer @ti-srebot @HunDunDM