Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiutil: refine the log errs in apiutil (#2722) #2912

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2722 to release-4.0


Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

To solve #2704

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@ti-srebot ti-srebot added component/api HTTP API. component/log Log. contribution This PR is from a community contributor. require-LGT1 Indicates that the PR requires an LGTM. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick labels Sep 7, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@howardlau1999
Copy link
Contributor

LGTM

@ti-srebot
Copy link
Contributor Author

@howardlau1999,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: scheduling(slack).

Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2020
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/api HTTP API. component/log Log. contribution This PR is from a community contributor. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants