Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refine the fatal log #2896

Merged
merged 1 commit into from
Sep 4, 2020
Merged

*: refine the fatal log #2896

merged 1 commit into from
Sep 4, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 4, 2020

What problem does this PR solve?

Part of #2704.

What is changed and how it works?

This PR refines all the fatal level log according to the RFC

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 4, 2020
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 4, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 4, 2020
@rleungx
Copy link
Member Author

rleungx commented Sep 4, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 4, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@rleungx
Copy link
Member Author

rleungx commented Sep 4, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@rleungx
Copy link
Member Author

rleungx commented Sep 4, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

1 similar comment
@ti-srebot
Copy link
Contributor

@rleungx merge failed.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Sep 4, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 67cc378 into tikv:master Sep 4, 2020
@rleungx rleungx added the needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. label Sep 7, 2020
ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Sep 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2907

rleungx added a commit to ti-srebot/pd that referenced this pull request Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to ti-srebot/pd that referenced this pull request Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-srebot added a commit that referenced this pull request Sep 7, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants