Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refine log in metricutil/etcdutil #2802

Merged
merged 3 commits into from
Aug 20, 2020
Merged

*: refine log in metricutil/etcdutil #2802

merged 3 commits into from
Aug 20, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 20, 2020

What problem does this PR solve?

Part of #2704.

What is changed and how it works?

This PR refines logs according to RFC and update the error dependency.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2020
@disksing
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit aeebecc into tikv:master Aug 20, 2020
Yisaer added a commit to Yisaer/pd that referenced this pull request Aug 20, 2020
Signed-off-by: lhy1024 <admin@liudos.us>

*: refine log in metricutil/etcdutil (tikv#2802)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

add error handling
howardlau1999 pushed a commit to howardlau1999/pd that referenced this pull request Aug 20, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ZenoTan pushed a commit to ZenoTan/pd that referenced this pull request Aug 24, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: ZenoTan <zenotan1998@gmail.com>
jyz0309 pushed a commit to jyz0309/pd that referenced this pull request Aug 24, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
jyz0309 pushed a commit to jyz0309/pd that referenced this pull request Aug 24, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants