*: update the error dependency and do the corresponding changes #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
force-pushed
the
update-error-format
branch
from
b0470b7
to
fcb2368
Compare
rleungx
added
the
do-not-merge/work-in-progress
rleungx
force-pushed
the
update-error-format
branch
2 times, most recently
from
5a4872d
to
cd4036b
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
update-error-format
branch
from
cd4036b
to
5359dfb
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
removed
the
do-not-merge/work-in-progress
|
@Yisaer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
|
@JmPotato,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
|
LGTM |
|
/merge |
|
@nolouch Oops! This PR requires at least 2 LGTMs to merge. The current number of |
nolouch
approved these changes
Aug 19, 2020
|
/merge |
|
@nolouch Oops! This PR requires at least 2 LGTMs to merge. The current number of |
nolouch
added
status/LGT2
|
/merge |
|
@nolouch Oops! This PR requires at least 2 LGTMs to merge. The current number of |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@rleungx merge failed. |
|
/merge |
|
/run-all-tests |
ZenoTan
pushed a commit
to ZenoTan/pd
that referenced
this pull request
Aug 24, 2020
…#2760) Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: ZenoTan <zenotan1998@gmail.com>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
…#2760) Signed-off-by: Ryan Leung <rleungx@gmail.com>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
…#2760) Signed-off-by: Ryan Leung <rleungx@gmail.com>
nolouch
added
the
needs-cherry-pick-release-4.0
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Sep 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2902 |
nolouch
pushed a commit
that referenced
this pull request
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related to #2704.
What is changed and how it works?
This PR updates the way to define an error and uses
WrapandFastGenWithCauseto output the internal error.Check List
Tests
Release note