Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support allowed Common Name(CN) #2241

Merged
merged 2 commits into from
Mar 16, 2020
Merged

*: support allowed Common Name(CN) #2241

merged 2 commits into from
Mar 16, 2020

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Mar 16, 2020

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

ref #2209.
support allowed Common Name(CN)

What is changed and how it works?

add filed allowed CN

Check List

Tests

  • Manual test

Signed-off-by: nolouch <nolouch@gmail.com>
pkg/grpcutil/grpcutil.go Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch added the type/enhancement The issue or PR belongs to an enhancement. label Mar 16, 2020
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor Author

nolouch commented Mar 16, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

@nolouch merge failed.

@nolouch
Copy link
Contributor Author

nolouch commented Mar 16, 2020

/rebuild

@nolouch nolouch added needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. labels Mar 16, 2020
@nolouch nolouch merged commit 58a64fc into tikv:master Mar 16, 2020
@nolouch nolouch deleted the supports-cn branch March 16, 2020 09:25
@nolouch nolouch restored the supports-cn branch March 16, 2020 09:25
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

cherry pick to release-3.1 in PR #2243

@nolouch nolouch deleted the supports-cn branch March 16, 2020 10:09
sre-bot added a commit that referenced this pull request Mar 18, 2020
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch pushed a commit to nolouch/pd that referenced this pull request Mar 18, 2020
Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants