Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix placement rules panic #2070

Merged
merged 2 commits into from
Dec 31, 2019
Merged

server: fix placement rules panic #2070

merged 2 commits into from
Dec 31, 2019

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing <i@disksing.com

What problem does this PR solve?

Fix #2069

What is changed and how it works?

Check if bootstrapped.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    when not bootstrapped:
./bin/pd-ctl config set enable-placement-rules true
Failed to set config: [500] "TiKV cluster not bootstrapped, please start TiKV first"

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added type/bug The issue is confirmed as a bug. component/schedule Scheduling logic. labels Dec 31, 2019
@disksing disksing added this to the v4.0.0-beta milestone Dec 31, 2019
@codecov-io
Copy link

codecov-io commented Dec 31, 2019

Codecov Report

Merging #2070 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2070      +/-   ##
==========================================
- Coverage   76.61%   76.54%   -0.07%     
==========================================
  Files         190      190              
  Lines       19279    19279              
==========================================
- Hits        14771    14758      -13     
- Misses       3378     3387       +9     
- Partials     1130     1134       +4
Impacted Files Coverage Δ
server/config/config.go 89.47% <ø> (ø) ⬆️
pkg/etcdutil/etcdutil.go 82.6% <0%> (-5.8%) ⬇️
server/tso/tso.go 77.37% <0%> (-2.92%) ⬇️
server/member/leader.go 75.51% <0%> (-1.03%) ⬇️
pkg/btree/btree.go 86.84% <0%> (-0.81%) ⬇️
server/cluster/cluster.go 81.16% <0%> (-0.46%) ⬇️
server/server.go 81.95% <0%> (-0.19%) ⬇️
server/core/storage.go 72.39% <0%> (ø) ⬆️
server/config/option.go 91.24% <0%> (+0.92%) ⬆️
server/kv/etcd_kv.go 75.32% <0%> (+2.59%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b876dd5...143bcda. Read the comment docs.

@lhy1024
Copy link
Contributor

lhy1024 commented Dec 31, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2019

/run-all-tests

@sre-bot sre-bot merged commit 8d883e5 into tikv:master Dec 31, 2019
@disksing disksing deleted the panic branch January 2, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic when enable placement rules
5 participants