-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: support manage the component configuration #1977
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Nov 28, 2019
rleungx
changed the title
support manage the component configuration
config: support manage the component configuration
Nov 28, 2019
30 tasks
NingLin-P
reviewed
Dec 3, 2019
NingLin-P
reviewed
Dec 3, 2019
NingLin-P
reviewed
Dec 3, 2019
NingLin-P
reviewed
Dec 3, 2019
NingLin-P
reviewed
Dec 3, 2019
rleungx
force-pushed
the
dynamic-config
branch
3 times, most recently
from
December 11, 2019 07:46
55a6b1b
to
90bee20
Compare
Codecov Report
@@ Coverage Diff @@
## master #1977 +/- ##
=========================================
- Coverage 77.7% 76.8% -0.91%
=========================================
Files 179 181 +2
Lines 18407 19102 +695
=========================================
+ Hits 14304 14671 +367
- Misses 3022 3303 +281
- Partials 1081 1128 +47
Continue to review full report at Codecov.
|
Merged
rleungx
force-pushed
the
dynamic-config
branch
from
December 16, 2019 12:28
61b6be9
to
629d3c9
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
dynamic-config
branch
from
December 18, 2019 03:58
629d3c9
to
c89a264
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
dynamic-config
branch
from
December 18, 2019 09:54
c89a264
to
6584bdd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Provide a way to manage components' configuration in the cluster.
What is changed and how it works?
This PR is a basic implementation.
Check List
Tests