Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add split support. #18

Merged
merged 1 commit into from
Mar 16, 2016
Merged

server: add split support. #18

merged 1 commit into from
Mar 16, 2016

Conversation

siddontang
Copy link
Contributor

disksing
disksing reviewed Mar 15, 2016
View reviewed changes
server/cluster_worker_test.go
c.Assert(right.GetStartKey(), BytesEquals, []byte("b"))
c.Assert(right.GetEndKey(), BytesEquals, []byte(""))

region, err = cluster.GetRegion([]byte("b"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why testing "b" twice? Maybe you want to test "c"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault.

@disksing
Copy link
Contributor

LGTM

@siddontang
Copy link
Contributor Author

PTAL @ngaut

ngaut
ngaut reviewed Mar 16, 2016
View reviewed changes
server/cluster_worker_test.go
newRegion.Peers[i] = &peer
}

newRegion.MaxPeerId = proto.Uint64(maxPeerID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to send max peer id. The raft group can calculate it automatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here simulates the raft group, so it should handle here.

@ngaut
Copy link
Member

ngaut commented Mar 16, 2016

LGTM

siddontang added a commit that referenced this pull request Mar 16, 2016
@siddontang
Merge pull request #18 from pingcap/siddontang/ask-split
c2c7228 
server: add split support.
@siddontang siddontang merged commit c2c7228 into master Mar 16, 2016
@siddontang siddontang deleted the siddontang/ask-split branch March 16, 2016 07:53
HuSharp pushed a commit to HuSharp/pd that referenced this pull request Feb 27, 2023
@disksing
6.6: add approixmate kv size (tikv#18) (tikv#26)
f76b7b2 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: disksing <i@disksing.com>
rleungx pushed a commit to rleungx/pd that referenced this pull request Jul 26, 2023
@disksing @rleungx
6.6: add approixmate kv size (tikv#18) (tikv#26)
03b6f02 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: disksing <i@disksing.com>
rleungx pushed a commit to rleungx/pd that referenced this pull request Jul 26, 2023
@disksing @rleungx
6.6: add approixmate kv size (tikv#18) (tikv#26)
7479b3c 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: disksing <i@disksing.com>
rleungx pushed a commit to rleungx/pd that referenced this pull request Jul 27, 2023
@disksing @rleungx
6.6: add approixmate kv size (tikv#18) (tikv#26)
d75c692 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: disksing <i@disksing.com>
rleungx pushed a commit to rleungx/pd that referenced this pull request Jul 28, 2023
@disksing @rleungx
6.6: add approixmate kv size (tikv#18) (tikv#26)
12fc611 
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: disksing <i@disksing.com>
@okJiang okJiang mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siddontang @disksing @ngaut