server: tolerate backslash in the label name #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shafreeck Sea <shafreeck@gmail.com> Closes tikv#1588
shafreeck
added
component/schedule
disksing
reviewed
Jun 24, 2019
Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>
disksing
approved these changes
Jun 24, 2019
nolouch
approved these changes
Jun 24, 2019
nolouch
added
needs-cherry-pick-release-3.0
|
/run-cherry-picker |
|
cherry pick to release-3.0 in PR #2083 |
|
cherry pick to release-3.1 in PR #2084 |
sre-bot
added a commit
that referenced
this pull request
Jan 7, 2020
sre-bot
added a commit
that referenced
this pull request
Jan 7, 2020
shafreeck
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shafreeck Sea shafreeck@gmail.com
Closes #1588
What problem does this PR solve?
tolerate backslash in the label name.
What is changed and how it works?
relax the rules to check the validation of a label.
Check List
Tests