Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: fix the issue about the limit of the hot region #1552

Merged
merged 1 commit into from
May 29, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 29, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

The auto adjust limit may become 0.

What is changed and how it works?

use 1 as min value.

Check List

Tests

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch requested review from disksing and rleungx May 29, 2019 04:03
@nolouch nolouch added the needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. label May 29, 2019
@codecov-io
Copy link

Codecov Report

Merging #1552 into master will decrease coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1552     +/-   ##
=========================================
- Coverage   67.75%   67.56%   -0.2%     
=========================================
  Files         159      159             
  Lines       16141    16138      -3     
=========================================
- Hits        10937    10903     -34     
- Misses       4250     4263     +13     
- Partials      954      972     +18
Impacted Files Coverage Δ
server/schedulers/hot_region.go 76.66% <100%> (+0.47%) ⬆️
pkg/tempurl/tempurl.go 57.14% <0%> (-14.29%) ⬇️
pkg/metricutil/metricutil.go 90.62% <0%> (-9.38%) ⬇️
pkg/etcdutil/etcdutil.go 86.04% <0%> (-9.31%) ⬇️
server/util.go 70.86% <0%> (-4.64%) ⬇️
server/etcd_kv.go 65.95% <0%> (-4.26%) ⬇️
server/namespace_cluster.go 81.81% <0%> (-3.9%) ⬇️
server/leader.go 80.81% <0%> (-3.68%) ⬇️
server/schedule/region_scatterer.go 86.23% <0%> (-2.18%) ⬇️
server/tso.go 74.46% <0%> (-2.13%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c44ddf4...def6db7. Read the comment docs.

@rleungx rleungx merged commit 915a75f into tikv:master May 29, 2019
@nolouch nolouch deleted the fix-hot-adjust branch May 29, 2019 06:42
nolouch added a commit to nolouch/pd that referenced this pull request Jul 3, 2019
disksing pushed a commit that referenced this pull request Jul 3, 2019
* schedulers: fix the issue about the limit of the hot region (#1552)

Signed-off-by: nolouch <nolouch@gmail.com>

* config: add a switch about grpc gateway (#1596)

Signed-off-by: nolouch <nolouch@gmail.com>

* statistics: add the missing schedule config items (#1601)

Signed-off-by: nolouch <nolouch@gmail.com>

* update changelog

Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the type/bug The issue is confirmed as a bug. label Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants