Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: replace gofail with pingcap/failpoint #1534

Merged
merged 8 commits into from
May 15, 2019
Merged

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Switch to pingcap/failpoint which is more elegant than gofail.

What is changed and how it works?

  • replace tool utilities
  • update Makefile
  • migrate old failpoints

Check List

Tests

  • Unit test

Signed-off-by: disksing <i@disksing.com>
@disksing disksing requested review from nolouch and rleungx May 14, 2019 06:17
Signed-off-by: disksing <i@disksing.com>
@nolouch
Copy link
Contributor

nolouch commented May 15, 2019

/ok-to-test

server/cluster.go Outdated Show resolved Hide resolved
server/cluster_test.go Outdated Show resolved Hide resolved
server/tso.go Outdated Show resolved Hide resolved
server/tso.go Outdated Show resolved Hide resolved
server/tso_test.go Outdated Show resolved Hide resolved
@lonng
Copy link
Member

lonng commented May 15, 2019

failpoint.Enable and failpoint.Disable may be return error.

disksing and others added 5 commits May 15, 2019 11:45
Signed-off-by: disksing <i@disksing.com>
Co-Authored-By: Lonng <chris@lonng.org>
Co-Authored-By: Lonng <chris@lonng.org>
Co-Authored-By: Lonng <chris@lonng.org>
Signed-off-by: disksing <i@disksing.com>
@disksing disksing force-pushed the failpoint branch 2 times, most recently from b016037 to ef6c82d Compare May 15, 2019 05:34
Co-Authored-By: Lonng <chris@lonng.org>
@zhouqiang-cl
Copy link
Contributor

/rebuild

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/rebuild

@disksing disksing merged commit 431c789 into tikv:master May 15, 2019
@disksing disksing deleted the failpoint branch May 15, 2019 06:16
nolouch added a commit that referenced this pull request May 23, 2019
* tiny clean up code (#1526)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config:  enable use region storage by default (#1524)

* config: default enable use region storage

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>

* log: do not add stack to error log (#1532)

* *: replace gofail with pingcap/failpoint (#1534)

* *: replace gofail with pingcap/failpoint

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster_test.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* check enable failpoint result

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster.go

Co-Authored-By: Lonng <chris@lonng.org>

* server: set timeout for MoveLeader (#1533)

* server: set timeout for MoveLeader

Signed-off-by: disksing <i@disksing.com>

* client, server: add ScanRegions gRPC protocol support (#1535)

* client, server: support ScanRegions gRPC protocol

Signed-off-by: disksing <i@disksing.com>

* schedule: actively push operator  (#1536)

* schedule: actively push operator

Signed-off-by: nolouch <nolouch@gmail.com>

* *: update some dead links (#1543)

* update links

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* Add windows build script (#1540)

Signed-off-by: Ana Hobden <operator@hoverbear.org>

* fix operator timeout metrics (#1541)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* *:Rollback config in store when kv.persist failed (#1476)

* tests: independent region sync test (#1545)

* tests: independent syncer region test

Signed-off-by: nolouch <nolouch@gmail.com>

* schedule: operator limit for stores (#1474)

* add store limit for scheduling

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* statistic: add the statistic of flow (#1548)

* store_statistic: add the statistic of flow

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants