Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: log format for logutil, server/core #1438

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Feb 22, 2019

What problem does this PR solve?

Format the log according to our RFC.

What is changed and how it works?

This PR is going to do the log format for the remaining packages.

Check List

Tests

  • Unit test

Signed-off-by: nolouch <nolouch@gmail.com>
@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@2d6cf4e). Click here to learn what that means.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1438   +/-   ##
=========================================
  Coverage          ?   67.83%           
=========================================
  Files             ?      158           
  Lines             ?    15167           
  Branches          ?        0           
=========================================
  Hits              ?    10289           
  Misses            ?     3956           
  Partials          ?      922
Impacted Files Coverage Δ
pkg/etcdutil/etcdutil.go 93.93% <ø> (ø)
server/core/region_kv.go 81.81% <0%> (ø)
server/core/store.go 78.27% <0%> (ø)
server/server.go 78.21% <100%> (ø)
server/api/log.go 66.66% <100%> (ø)
server/cache/ttl.go 100% <100%> (ø)
server/core/region_tree.go 97.67% <100%> (ø)
pkg/logutil/log.go 85.27% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6cf4e...50f8c6f. Read the comment docs.

server/core/region_kv.go Outdated Show resolved Hide resolved
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch added the component/log Log. label Feb 25, 2019
@nolouch nolouch merged commit c996046 into tikv:master Feb 26, 2019
@nolouch nolouch deleted the remaining-log branch February 26, 2019 06:00
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* *: log format for logutil,server/core
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* *: log format for logutil,server/core
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* *: log format for logutil,server/core
nolouch added a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* *: log format for logutil,server/core
youjiali1995 pushed a commit that referenced this pull request Jul 17, 2019
* *:Start swithing to the zap logger (#1422)

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for schedule, scheduler, syncer, api (#1423)

* log format for schedule, scheduler, syncer, api

Signed-off-by: rleungx <rleungx@gmail.com>

* pdctl, api: support hex format keys (#1309)

pdctl, api: support hex format keys

Signed-off-by: disksing <i@disksing.com>

* *: log format for tools, client, pkg, table (#1424)

* log format for tools, client, pkg, table, simulator

Signed-off-by: rleungx <rleungx@gmail.com>

* *: log format for server (#1431)

* *: log format for server

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for logutil, server/core (#1438)

* *: log format for logutil,server/core

* *: improve some logs (#1516)

* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* log: do not add stack to error log (#1532)

* pkg, tools: improve the log message (#1636)

* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>

* core: use hex format for region meta key (#1627)

Signed-off-by: Ryan Leung <rleungx@gmail.com>=

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants