server: Fix transfer leader log error #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
@siddontang PTAL |
|
LGTM |
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Jul 26, 2023
* keyspace: create a disabled keyspace meta before split tikv-server need to get the keyspace encryption config on keyspace creation. If we split before save the meta, tikv-server can not get the meta. Signed-off-by: Evan Zhou <coocood@gmail.com> * UpdateKeyspaceStateByID instead of saveNewKeyspace Signed-off-by: Evan Zhou <coocood@gmail.com> * remove pre-created keyspace after split failed. Signed-off-by: Evan Zhou <coocood@gmail.com> --------- Signed-off-by: Evan Zhou <coocood@gmail.com>
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Jul 26, 2023
* keyspace: create a disabled keyspace meta before split tikv-server need to get the keyspace encryption config on keyspace creation. If we split before save the meta, tikv-server can not get the meta. Signed-off-by: Evan Zhou <coocood@gmail.com> * UpdateKeyspaceStateByID instead of saveNewKeyspace Signed-off-by: Evan Zhou <coocood@gmail.com> * remove pre-created keyspace after split failed. Signed-off-by: Evan Zhou <coocood@gmail.com> --------- Signed-off-by: Evan Zhou <coocood@gmail.com>
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Jul 27, 2023
* keyspace: create a disabled keyspace meta before split tikv-server need to get the keyspace encryption config on keyspace creation. If we split before save the meta, tikv-server can not get the meta. Signed-off-by: Evan Zhou <coocood@gmail.com> * UpdateKeyspaceStateByID instead of saveNewKeyspace Signed-off-by: Evan Zhou <coocood@gmail.com> * remove pre-created keyspace after split failed. Signed-off-by: Evan Zhou <coocood@gmail.com> --------- Signed-off-by: Evan Zhou <coocood@gmail.com>
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Jul 28, 2023
* keyspace: create a disabled keyspace meta before split tikv-server need to get the keyspace encryption config on keyspace creation. If we split before save the meta, tikv-server can not get the meta. Signed-off-by: Evan Zhou <coocood@gmail.com> * UpdateKeyspaceStateByID instead of saveNewKeyspace Signed-off-by: Evan Zhou <coocood@gmail.com> * remove pre-created keyspace after split failed. Signed-off-by: Evan Zhou <coocood@gmail.com> --------- Signed-off-by: Evan Zhou <coocood@gmail.com>
JmPotato
pushed a commit
to JmPotato/pd
that referenced
this pull request
Sep 25, 2023
* keyspace: create a disabled keyspace meta before split tikv-server need to get the keyspace encryption config on keyspace creation. If we split before save the meta, tikv-server can not get the meta. Signed-off-by: Evan Zhou <coocood@gmail.com> * UpdateKeyspaceStateByID instead of saveNewKeyspace Signed-off-by: Evan Zhou <coocood@gmail.com> * remove pre-created keyspace after split failed. Signed-off-by: Evan Zhou <coocood@gmail.com> --------- Signed-off-by: Evan Zhou <coocood@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.