Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable merge result caused by waitFinishMerge func #7051

Closed
JmPotato opened this issue Sep 6, 2023 · 0 comments · Fixed by #7052
Closed

Unstable merge result caused by waitFinishMerge func #7051

JmPotato opened this issue Sep 6, 2023 · 0 comments · Fixed by #7052
Labels
type/ci The issue is related to CI.

Comments

@JmPotato
Copy link
Member

JmPotato commented Sep 6, 2023

Flaky Test

Which jobs are failing

TestTSOKeyspaceGroupManager/TestKeyspaceGroupMergeIntoDefault

CI link

https://github.com/tikv/pd/actions/runs/6094187714/job/16535219250?pr=7032

Reason for failure (if possible)

waitFinishMerge should assert the keyspace list after the merge is finished rather than every time.
@JmPotato JmPotato added the type/ci The issue is related to CI. label Sep 6, 2023
@JmPotato JmPotato mentioned this issue Sep 6, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #7052 Sep 6, 2023
ti-chi-bot bot pushed a commit that referenced this issue Sep 6, 2023
@JmPotato
tests: fix waitFinishMerge to stablize the merge test (#7052)
41eae1a 
close #7051

Make `waitFinishMerge` assert the keyspace list after the merge is finished rather than every time.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/ci The issue is related to CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: fix waitFinishMerge to stablize the merge test JmPotato/pd
1 participant
@JmPotato