Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSO microservice discovery fallback path shouldn't call FindGroupByKeyspaceID #6472

Closed
binshi-bing opened this issue May 16, 2023 · 0 comments · Fixed by #6473
Closed

TSO microservice discovery fallback path shouldn't call FindGroupByKeyspaceID #6472

binshi-bing opened this issue May 16, 2023 · 0 comments · Fixed by #6473
Labels
severity/major type/bug The issue is confirmed as a bug.

Comments

@binshi-bing
Copy link
Contributor

binshi-bing commented May 16, 2023 •
edited
Loading

Bug Report

What did you do?

Upgraded the client version so that the client side support GetClusterInfo.TsoUrls and FindGroupByKeyspaceID but the server side doesn't, then called GetTS().
Issue Number: Ref #5895

What did you expect to see?

Successfully fallback to the legacy path to discover the primary server of the default keyspace group.

What did you see instead?

Returned "FindGroupByKeyspaceID not implemented"

What version of PD are you using (pd-server -V)?

TiKV/master for tso microservice in cloud
@binshi-bing binshi-bing added the type/bug The issue is confirmed as a bug. label May 16, 2023
@binshi-bing binshi-bing mentioned this issue May 16, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 16, 2023
@binshi-bing
TSO microservice discovery fallback path shouldn't call FindGroupByKe…
53b34ea 
…yspaceID (#6473)

close #6472

TSO microservice discovery fallback path shouldn't call FindGroupByKeyspaceID

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
TSO microservice discovery fallback path shouldn't call FindGroupByKe…
56385f8 
…yspaceID (tikv#6473)

close tikv#6472

TSO microservice discovery fallback path shouldn't call FindGroupByKeyspaceID

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TSO microservice discovery fallback path shouldn't call FindGroupByKeyspaceID binshi-bing/pd
2 participants
@rleungx @binshi-bing