Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestMicroserviceTSOClient is unstable #6404

Closed
lhy1024 opened this issue May 5, 2023 · 0 comments · Fixed by #6410
Closed

TestMicroserviceTSOClient is unstable #6404

lhy1024 opened this issue May 5, 2023 · 0 comments · Fixed by #6410
Labels
type/ci The issue is related to CI.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented May 5, 2023

Flaky Test

Which jobs are failing

2023-05-04T09:46:23.2243681Z --- FAIL: TestMicroserviceTSOClient (62.37s)
2023-05-04T09:46:23.2244039Z     --- FAIL: TestMicroserviceTSOClient/TestRandomResignLeader (6.06s)
2023-05-04T09:46:23.2244241Z         client_test.go:254: 
2023-05-04T09:46:23.2244766Z             	Error Trace:	/home/runner/work/pd/pd/tests/integrations/tso/client_test.go:254
2023-05-04T09:46:23.2245525Z             	            				/opt/hostedtoolcache/go/1.20.1/x64/src/runtime/asm_amd64.s:1598
2023-05-04T09:46:23.2245821Z             	Error:      	Received unexpected error:
2023-05-04T09:46:23.2246290Z             	            	no tso server serves this keyspace 0
2023-05-04T09:46:23.2246714Z             	Test:       	TestMicroserviceTSOClient/TestRandomResignLeader

CI link

https://github.com/tikv/pd/actions/runs/4881259391/jobs/8709936593

Reason for failure (if possible)

Anything else
@lhy1024 lhy1024 added the type/ci The issue is related to CI. label May 5, 2023
@binshi-bing binshi-bing mentioned this issue May 5, 2023
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #6410 May 5, 2023
ti-chi-bot bot pushed a commit that referenced this issue May 5, 2023
@binshi-bing
Fix test issue in TestRandomResignLeader. (#6410)
09e6531 
close #6404

We need to make sure the selected keyspaces are from different keyspace groups, otherwise multiple goroutines below could try to resign the primary of the same keyspace group and cause race condition.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
zeminzhou pushed a commit to zeminzhou/pd that referenced this issue May 8, 2023
@binshi-bing @zeminzhou
Fix test issue in TestRandomResignLeader. (tikv#6410)
1a9c6a6 
close tikv#6404

We need to make sure the selected keyspaces are from different keyspace groups, otherwise multiple goroutines below could try to resign the primary of the same keyspace group and cause race condition.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
zeminzhou pushed a commit to zeminzhou/pd that referenced this issue May 10, 2023
@binshi-bing @zeminzhou
Fix test issue in TestRandomResignLeader. (tikv#6410)
583fa11 
close tikv#6404

We need to make sure the selected keyspaces are from different keyspace groups, otherwise multiple goroutines below could try to resign the primary of the same keyspace group and cause race condition.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
Fix test issue in TestRandomResignLeader. (tikv#6410)
fde5981 
close tikv#6404

We need to make sure the selected keyspaces are from different keyspace groups, otherwise multiple goroutines below could try to resign the primary of the same keyspace group and cause race condition.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/ci The issue is related to CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test issue in TestRandomResignLeader. binshi-bing/pd
1 participant
@lhy1024