-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The error returned by PD gRPC service is not expected #5161
Labels
Comments
/Severity Minor |
/severity Minor |
@mayjiang0203 Should we level it up to major, it may cause pd client of TiKV to reconnect again and again which greatly affects the performance |
I found there are still some errors that are not well handled. |
nolouch
pushed a commit
to nolouch/pd
that referenced
this issue
Jun 30, 2023
nolouch
pushed a commit
to nolouch/pd
that referenced
this issue
Jun 30, 2023
ti-chi-bot bot
pushed a commit
that referenced
this issue
Jun 30, 2023
close #5161, ref #5309, ref #5310, ref pingcap/tiflash#7408 put the unknown error into the header instead of directly returning a gRPC error. Signed-off-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: Hu# <jinhao.hu@pingcap.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
See
pd/server/grpc_service.go
Line 470 in d263b85
We should put the error into the header instead of directly returning a gRPC error.
What version of PD are you using (
pd-server -V
)?master
The text was updated successfully, but these errors were encountered: