Skip to content

Commit

Permalink
remove client close
Browse files Browse the repository at this point in the history
Signed-off-by: husharp <jinhao.hu@pingcap.com>
  • Loading branch information
HuSharp committed Jan 2, 2024
1 parent f89b164 commit fa30740
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 13 deletions.
4 changes: 0 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ WORKDIR /go/src/github.com/tikv/pd
COPY go.mod .
COPY go.sum .

RUN mkdir -p client
COPY ./client/go.mod ./client
COPY ./client/go.sum ./client

RUN GO111MODULE=on go mod download

COPY . .
Expand Down
3 changes: 0 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ require (
github.com/swaggo/http-swagger v1.2.6
github.com/swaggo/swag v1.8.3
github.com/syndtr/goleveldb v1.0.1-0.20190318030020-c3a204f8e965
github.com/tikv/pd/tools v0.0.0-20231229094228-a67ccbb8165f
github.com/unrolled/render v1.0.1
github.com/urfave/negroni v0.3.0
go.etcd.io/etcd v0.5.0-alpha.5.0.20220915004622-85b640cee793
Expand Down Expand Up @@ -207,8 +206,6 @@ require (

replace google.golang.org/grpc v1.59.0 => google.golang.org/grpc v1.26.0

replace github.com/tikv/pd/client => ./client

// When you modify PD cooperatively with kvproto, this will be useful to submit the PR to PD and the PR to
// kvproto at the same time. You can run `go mod tidy` to make it replaced with go-mod style specification.
// After the PR to kvproto is merged, remember to comment this out and run `go mod tidy`.
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,6 @@ github.com/tidwall/match v1.1.1/go.mod h1:eRSPERbgtNPcGhD8UCthc6PmLEQXEWd3PRB5JT
github.com/tidwall/pretty v1.0.0/go.mod h1:XNkn88O1ChpSDQmQeStsy+sBenx6DDtFZJxhVysOjyk=
github.com/tidwall/pretty v1.2.0 h1:RWIZEg2iJ8/g6fDDYzMpobmaoGh5OLl4AXtGUGPcqCs=
github.com/tidwall/pretty v1.2.0/go.mod h1:ITEVvHYasfjBbM0u2Pg8T2nJnzm8xPwvNhhsoaGGjNU=
github.com/tikv/pd/tools v0.0.0-20231229094228-a67ccbb8165f h1:6G06VuBHvXg8M4RkmszuDZsLtsCbRLHapPnXHVyKrH4=
github.com/tikv/pd/tools v0.0.0-20231229094228-a67ccbb8165f/go.mod h1:OnWHDcm59mwbeLa1mFk4k94vBKpEBFliZq37B0UyWsQ=
github.com/tklauser/go-sysconf v0.3.9/go.mod h1:11DU/5sG7UexIrp/O6g35hrWzu0JxlwQ3LSFUzyeuhs=
github.com/tklauser/go-sysconf v0.3.11 h1:89WgdJhk5SNwJfu+GKyYveZ4IaJ7xAkecBo+KdJV0CM=
github.com/tklauser/go-sysconf v0.3.11/go.mod h1:GqXfhXY3kiPa0nAXPDIQIWzJbMCB7AmcWpGR8lSZfqI=
Expand Down
4 changes: 0 additions & 4 deletions tests/dashboard/service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
"context"
"encoding/json"
"fmt"
"github.com/tikv/pd/tools/pd-ctl/pdctl/command"
"io"
"net/http"
"testing"
Expand Down Expand Up @@ -66,9 +65,6 @@ func (suite *dashboardTestSuite) SetupSuite() {
func (suite *dashboardTestSuite) TearDownSuite() {
suite.cancel()
suite.httpClient.CloseIdleConnections()
if command.PDCli != nil {
command.PDCli.Close()
}
dashboard.SetCheckInterval(time.Second)
}

Expand Down

0 comments on commit fa30740

Please sign in to comment.