Skip to content

Commit

Permalink
fix member race problem
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Leung <rleungx@gmail.com>
  • Loading branch information
rleungx committed Mar 2, 2023
1 parent c82b237 commit dec0bdc
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion server/grpc_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,17 @@ func (s *GrpcServer) wrapErrorToHeader(errorType pdpb.ErrorType, message string)
func (s *GrpcServer) GetMembers(context.Context, *pdpb.GetMembersRequest) (*pdpb.GetMembersResponse, error) {
// Here we purposely do not check the cluster ID because the client does not know the correct cluster ID
// at startup and needs to get the cluster ID with the first request (i.e. GetMembers).
members, err := s.Server.GetMembers()
if s.IsClosed() {
return &pdpb.GetMembersResponse{
Header: &pdpb.ResponseHeader{
Error: &pdpb.Error{
Type: pdpb.ErrorType_UNKNOWN,
Message: errs.ErrServerNotStarted.FastGenByArgs().Error(),
},
},
}, nil
}
members, err := cluster.GetMembers(s.GetClient())
if err != nil {
return &pdpb.GetMembersResponse{
Header: s.wrapErrorToHeader(pdpb.ErrorType_UNKNOWN, err.Error()),
Expand Down

0 comments on commit dec0bdc

Please sign in to comment.