fix RegionStatsNeedUpdate condition

Signed-off-by: Ryan Leung <rleungx@gmail.com>
tikv · Apr 28, 2024 · dcd6fb5 · dcd6fb5
1 parent aae410f
commit dcd6fb5
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/pkg/statistics/region_collection.go b/pkg/statistics/region_collection.go
@@ -158,14 +158,14 @@ func (r *RegionStatistics) RegionStatsNeedUpdate(region *core.RegionInfo) bool {
 		region.IsOversized(int64(r.conf.GetRegionMaxSize()), int64(r.conf.GetRegionMaxKeys())) {
 		return true
 	}
-	// expected to be zero for below type
-	if r.IsRegionStatsType(regionID, PendingPeer) && len(region.GetPendingPeers()) == 0 {
+
+	if r.IsRegionStatsType(regionID, PendingPeer) != (len(region.GetPendingPeers()) != 0) {
 		return true
 	}
-	if r.IsRegionStatsType(regionID, DownPeer) && len(region.GetDownPeers()) == 0 {
+	if r.IsRegionStatsType(regionID, DownPeer) != (len(region.GetDownPeers()) != 0) {
 		return true
 	}
-	if r.IsRegionStatsType(regionID, LearnerPeer) && len(region.GetLearners()) == 0 {
+	if r.IsRegionStatsType(regionID, LearnerPeer) != (len(region.GetLearners()) != 0) {
 		return true
 	}