address comment

tikv · Apr 19, 2018 · 562cd4a · 562cd4a
1 parent 17fdf95
commit 562cd4a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/server/coordinator_test.go b/server/coordinator_test.go
@@ -66,7 +66,7 @@ func (c *testClusterInfo) addRegionStore(storeID uint64, regionCount int) {
 	store.RegionCount = regionCount
 	store.RegionSize = int64(regionCount) * 10
 	store.Stats.Capacity = 1000 * (1 << 20)
-	store.Stats.Available = store.Stats.Capacity - uint64(store.LeaderSize)
+	store.Stats.Available = store.Stats.Capacity - uint64(store.RegionSize)
 	c.putStore(store)
 }
 

diff --git a/server/core/store.go b/server/core/store.go
@@ -127,6 +127,7 @@ func (s *StoreInfo) RegionScore(highSpaceRatio, lowSpaceRatio float64, delta int
 		lowSpaceRatio = highSpaceRatio
 	}
 
+	// because of rocksdb compression, region size is larger than actual used size
 	amplification := float64(s.RegionSize) / (float64(s.Stats.GetUsedSize()) / (1 << 20))
 
 	if available-float64(delta)/amplification >= highSpaceRatio*capacity || lowSpaceRatio < 0 || lowSpaceRatio > 1 {

diff --git a/server/schedule/mockcluster.go b/server/schedule/mockcluster.go
@@ -25,7 +25,7 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
-// MockCluster is to mock clusterInfo for test use
+// MockCluster is used to mock clusterInfo for test use
 type MockCluster struct {
 	*BasicCluster
 	id *core.MockIDAllocator