review comments

Signed-off-by: rishabh_mittal <mittalrishabh@gmail.com>
tikv · Aug 18, 2023 · 46cec29 · 46cec29
1 parent e4117f1
commit 46cec29
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/server/grpc_service.go b/server/grpc_service.go
@@ -1620,13 +1620,19 @@ func (s *GrpcServer) ScatterRegion(ctx context.Context, request *pdpb.ScatterReg
 	if err != nil {
 		return nil, err
 	}
-	if op != nil {
-		if op != nil && !rc.GetOperatorController().AddOperator(op) {
-			return &pdpb.ScatterRegionResponse{
-				Header: s.wrapErrorToHeader(pdpb.ErrorType_UNKNOWN,
-					"operator cancelled because store limit exceeded"),
-			}, nil
-		}
+
+	if op == nil {
+		return &pdpb.ScatterRegionResponse{
+			Header: s.wrapErrorToHeader(pdpb.ErrorType_UNKNOWN,
+				"operator could not be allocated"),
+		}, nil
+	}
+
+	if !rc.GetOperatorController().AddOperator(op) {
+		return &pdpb.ScatterRegionResponse{
+			Header: s.wrapErrorToHeader(pdpb.ErrorType_UNKNOWN,
+				"operator cancelled because store limit exceeded"),
+		}, nil
 	}
 
 	return &pdpb.ScatterRegionResponse{