improve the keep alive worker

Signed-off-by: Ryan Leung <rleungx@gmail.com>
tikv · Aug 9, 2023 · 0183048 · 0183048
1 parent ebd2cfe
commit 0183048
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/election/lease.go b/pkg/election/lease.go
@@ -174,8 +174,11 @@ func (l *lease) keepAliveWorker(ctx context.Context, interval time.Duration) <-c
 					expire := start.Add(time.Duration(res.TTL) * time.Second)
 					select {
 					case ch <- expire:
-					case <-ctx1.Done():
+					// Here we don't use `ctx1.Done()` because we want to make sure if the keep alive success, we can update the expire time.
+					case <-ctx.Done():
 					}
+				} else {
+					log.Error("keep alive response ttl is zero", zap.String("purpose", l.Purpose))
 				}
 			}()