Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump 0.6.0 #95

Merged
merged 2 commits into from
Jul 14, 2024
Merged

*: bump 0.6.0 #95

merged 2 commits into from
Jul 14, 2024

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Jul 14, 2024

No description provided.

Signed-off-by: Jay Lee <busyjaylee@gmail.com>
Signed-off-by: Jay Lee <busyjaylee@gmail.com>
@@ -32,7 +33,7 @@ libc = { version = "^0.2.8", default-features = false }
cc = "^1.0.13"

[features]
default = ["stats", "background_threads_runtime_support"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering we are releasing a new minor version, "stats" is removed from the default features to make it easier to control features.

/cc @girlbossceo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any strong reason blocking us from just increasing the patch version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now jemalloc-sys will disable jemalloc stats explicitly if stats feature is not enabled. This may break crates that rely on jemalloc stats but not enable it explicitly. To avoid breaking compatibility (though it's a bug), stats feature was added to the default feature set. But it still breaks those crates that disable the default features. It's more clear to upgrade to a new minor version and ask everyone relies on stats feature to enable it explicitly.

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@BusyJay BusyJay merged commit f260a80 into main Jul 14, 2024
9 checks passed
@BusyJay BusyJay deleted the bump-0.6.0 branch July 14, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants