fix: compile aarch64-linux-android binary on linux when enable lto. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
reviewed
Apr 30, 2024
jemalloc-sys/build.rs
Outdated
| @@ -338,6 +338,11 @@ fn main() { | |||
| println!("cargo:rustc-link-lib=atomic"); | |||
| } | |||
| println!("cargo:rerun-if-changed=jemalloc"); | |||
|
|
|||
| cc::Build::new() | |||
There was a problem hiding this comment.
Should only be built for android.
jemalloc-sys/src/pthread_atfork.c
Outdated
| // we're building on doesn't have them defined, so just make sure the symbols | ||
| // are available. | ||
| __attribute__((weak)) int | ||
| pthread_atfork(uint8_t *prefork __attribute__((unused)), |
There was a problem hiding this comment.
Should use the definition from https://man7.org/linux/man-pages/man3/pthread_atfork.3.html. The original definition is just for convenient.
|
PTAL @BusyJay |
|
You need to sign off your commits. |
fengys1996
force-pushed
the
fix/build_error
branch
from
fad8165
to
a1a0167
Compare
Done. |
BusyJay
reviewed
May 3, 2024
jemalloc-sys/src/pthread_atfork.c
Outdated
| @@ -0,0 +1,13 @@ | |||
| #include <pthread.h> | |||
There was a problem hiding this comment.
I don't think you need to include this header.
Signed-off-by: fys <fengys1996@gmail.com>
Signed-off-by: fys <fengys1996@gmail.com>
fengys1996
force-pushed
the
fix/build_error
branch
from
732485c
to
bbd97f3
Compare
BusyJay
approved these changes
May 5, 2024
|
Thank you! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
pthread_atforkfrom a strong symbol to a weak symbol.Related issue
#81